[Webkit-unassigned] [Bug 261056] AX: Expose accessibility attributes for inline text predictions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 11 06:54:54 PDT 2023


--- Comment #19 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Joshua Hoffman from comment #17)
> Created attachment 467596 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
+++ b/Source/WebCore/accessibility/AccessibilityObject.cpp

+void AccessibilityObject::setLastPresentedTextPrediction(Node& previousCompositionNode, CompositionState state, String text, size_t location, bool handlingAcceptedCandidate)

This should be in AccessibilityObjectIOS.mm instead. 

--- a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
+++ b/Source/WebCore/accessibility/AccessibilityObjectInterface.h

+enum class CompositionState : uint8_t { Started, InProgress, Ended };

Could we have Accepted as another CompositionState? As opposed to a separate state/variable/param?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230911/71f3328a/attachment.htm>

More information about the webkit-unassigned mailing list