[Webkit-unassigned] [Bug 260409] Empty files should not succeed in loading (as WebVTT)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260409

Anne van Kesteren <annevk at annevk.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |annevk at annevk.nl

--- Comment #3 from Anne van Kesteren <annevk at annevk.nl> ---
I was thinking of fixing this in TextTrackLoader::notifyFinished by changing

if (m_cueParser)
    m_cueParser->fileFinished();

to

if (m_cueParser)
    m_cueParser->fileFinished();
else
    m_state = Failed;

but I'm not sure if that would similarly regress tests.

However, looking closely at your commit it seems that WebKit would still invoke processNewCueData for the non-Failed states whereas Chromium would not (at least not at that point in time).

Syncing webvtt WPT is probably a good next step here. I can maybe do that today between meetings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230908/f6a94208/attachment.htm>