[Webkit-unassigned] [Bug 261298] New: Make TranslateTransformOperation::X/Y return const Length&

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=261298

            Bug ID: 261298
           Summary: Make TranslateTransformOperation::X/Y return const
                    Length&
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, mattwoodrow at apple.com,
                    simon.fraser at apple.com, zalan at apple.com

Hi Team,


Based on discussion with Matt over email, it makes sense to merge but it does not have much benefit but still good to add.

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/970821

GitHub WebKit Source: https://github.com/WebKit/WebKit/blob/641608e9630336fbbd011dc072655ee83bdf7b03/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h#L56 etc.

___

Local Patch in .h:

 const Length& x() const { return m_x; }
 const Length& y() const { return m_y; }

and in .cpp:

const auto* fromOp = downcast<TranslateTransformOperation>(from);
    const Length& fromX = fromOp ? fromOp->m_x : zeroLength;
    const Length& fromY = fromOp ? fromOp->m_y : zeroLength;

____

Just wanted to raise to merge it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230907/1d85222d/attachment-0001.htm>