[Webkit-unassigned] [Bug 261056] AX: Expose accessibility attributes for inline text predictions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=261056

--- Comment #11 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Joshua Hoffman from comment #10)
> Created attachment 467570 [details]
> Patch

--- a/Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
+++ b/Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm

+static void attributedStringSetCompositionAttributes(NSMutableAttributedString *attributedString, Node& node)

Does this need to be different from the same function in AccessibilityObjectMac.mm? Or can we have a common COCOA function?

+    if (&node != editor.compositionNode())
+        return;


Seems like this check should be earlier in the function, same as in the MAC version.

--- a/Source/WebCore/editing/Editor.cpp
+++ b/Source/WebCore/editing/Editor.cpp

             cache->onTextCompositionChange(*previousCompositionNode, state, true);
+
+            // WebKit needs to store inline-predicted words to expose their position and text values to assistive technologies.
+            if (state == AXObjectCache::CompositionState::Ended && !m_lastPresentedTextPrediction.text.isEmpty()) {
+                String previousCompositionNodeText = previousCompositionNode->wholeText();
+                size_t wordStart = 0;
+                if (previousCompositionNodeText.length()) {
+                    for (size_t position = previousCompositionNodeText.length() - 1; position > 0; position--) {
+                        if (isASCIIWhitespace(previousCompositionNodeText[position])) {
+                            wordStart = position + 1;
+                            break;
+                        }
+                    }
+                }
+                previousCompositionNodeText = previousCompositionNodeText.substring(wordStart);
+
+                String completePredictedWord = makeString(previousCompositionNodeText, m_lastPresentedTextPrediction.text);
+                m_lastPresentedTextPredictionComplete = { completePredictedWord, wordStart };
+
+                // Reset last presented prediction since a candidate was accepted.
+                m_lastPresentedTextPrediction.reset();
+            }
         }
         if (m_compositionNode) {
             auto state = previousCompositionNode ? AXObjectCache::CompositionState::InProgress : AXObjectCache::CompositionState::Started;
             cache->onTextCompositionChange(*m_compositionNode, state, true);
+            m_lastPresentedTextPredictionComplete.reset();

Instead of keeping these variables in the Editor, I wondering if it would make more sense to pass them as context to AXObjectCache::onTextCompositionChange.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230906/ed027846/attachment.htm>