[Webkit-unassigned] [Bug 261160] New: REGRESSION(267629 at main): Bindings tests JSTestGlobalObject.cpp and JSTestConditionallyReadWrite.cpp are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=261160

            Bug ID: 261160
           Summary: REGRESSION(267629 at main): Bindings tests
                    JSTestGlobalObject.cpp and
                    JSTestConditionallyReadWrite.cpp are failing
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Bindings
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at redhat.com
                CC: cdumez at apple.com

Looks like we need to update the bindings test expectations after 267629 at main:

FAIL: (JS) JSTestGlobalObject.cpp
--- WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp     2023-09-01 12:39:01.584862549 -0500
+++ /tmp/tmpmpa6h8z8/JSTestGlobalObject.cpp     2023-09-05 10:27:33.314132664 -0500
@@ -253,7 +253,7 @@
 /* Hash table */
 #if PLATFORM(MAC)

-static const struct CompactHashIndex JSTestGlobalObjectTableIndex[268] = {
+static const struct CompactHashIndex JSTestGlobalObjectTableIndex[269] = {
     { -1, -1 },
     { 43, -1 },
     { -1, -1 },
@@ -356,7 +356,7 @@
     { 20, -1 },
     { -1, -1 },
     { -1, -1 },
-    { 50, -1 },
+    { -1, -1 },
     { -1, -1 },
     { 38, -1 },
     { -1, -1 },
@@ -414,7 +414,7 @@
     { -1, -1 },
     { 67, -1 },
     { -1, -1 },
-    { 68, -1 },
+    { 50, 267 },
     { -1, -1 },
     { 29, -1 },
     { 34, -1 },
@@ -438,7 +438,7 @@
     { -1, -1 },
     { -1, -1 },
     { -1, -1 },
-    { 36, 267 },
+    { 36, 268 },
     { -1, -1 },
     { 18, 256 },
     { -1, -1 },
@@ -521,6 +521,7 @@
     { 53, -1 },
     { 58, -1 },
     { 64, -1 },
+    { 68, -1 },
     { 69, -1 },
 };


FAIL: (JS) JSTestConditionallyReadWrite.cpp
--- WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp   2023-08-30 14:16:29.654533770 -0500
+++ /tmp/tmpx45bqihm/JSTestConditionallyReadWrite.cpp   2023-09-05 10:27:38.405260145 -0500
@@ -110,6 +110,23 @@
 using JSTestConditionallyReadWriteDOMConstructor = JSDOMConstructorNotConstructable<JSTestConditionallyReadWrite>;

 /* Hash table */
+#if PLATFORM(MAC)
+
+static const struct CompactHashIndex JSTestConditionallyReadWriteTableIndex[4] = {
+    { -1, -1 },
+    { 0, -1 },
+    { -1, -1 },
+    { -1, -1 },
+};
+
+
+static const HashTableValue JSTestConditionallyReadWriteTableValues[] =
+{
+    { "enabledConditionallyReadWriteBySettingAttributeUnforgeable"_s, JSC::PropertyAttribute::DontDelete | JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute, NoIntrinsic, { HashTableValue::GetterSetterType, jsTestConditionallyReadWrite_enabledConditionallyReadWriteBySettingAttributeUnforgeable, setJSTestConditionallyReadWrite_enabledConditionallyReadWriteBySettingAttributeUnforgeable } },
+};
+
+static const HashTable JSTestConditionallyReadWriteTable = { 1, 3, static_cast<uint8_t>(JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute | JSC::PropertyAttribute::DontDelete), JSTestConditionallyReadWrite::info(), JSTestConditionallyReadWriteTableValues, JSTestConditionallyReadWriteTableIndex };
+#else

 static const struct CompactHashIndex JSTestConditionallyReadWriteTableIndex[4] = {
     { 0, -1 },
@@ -125,6 +142,7 @@
 };

 static const HashTable JSTestConditionallyReadWriteTable = { 1, 3, static_cast<uint8_t>(JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute | JSC::PropertyAttribute::DontDelete), JSTestConditionallyReadWrite::info(), JSTestConditionallyReadWriteTableValues, JSTestConditionallyReadWriteTableIndex };
+#endif
 template<> const ClassInfo JSTestConditionallyReadWriteDOMConstructor::s_info = { "TestConditionallyReadWrite"_s, &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(JSTestConditionallyReadWriteDOMConstructor) };

 template<> JSValue JSTestConditionallyReadWriteDOMConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230905/38de551b/attachment.htm>