[Webkit-unassigned] [Bug 261073] New: AutoInstaller unable to distinguish 2.0.0 and 2.0.0.dev0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=261073

            Bug ID: 261073
           Summary: AutoInstaller unable to distinguish 2.0.0 and
                    2.0.0.dev0
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com
                CC: jbedard at apple.com

If you try to AutoInstall hiredis 2.0.0, autoinstall.Package.archives will find two packages:

(Pdb) pp self.archives()
[hiredis-2.0.0, hiredis-2.0.0]
(Pdb) pp self.archives()[0].link
'https://files.pythonhosted.org/packages/0c/39/eae11344d69ba435ec13d6bcc1a9eea3d2278324506fcd0e52d1ed8958c8/hiredis-2.0.0.tar.gz'
(Pdb) pp self.archives()[1].link
'https://files.pythonhosted.org/packages/24/4d/404526ef79b397900aee60f83e0c7f3d8d4740758b29f086db3d2d1f2409/hiredis-2.0.0.dev0.tar.gz'

Given we're meant to be doing exact matching, the latter shouldn't match.

Surprisingly, we seem to install the self.archives()[-1], which given the ordering of pypi.org will give us the oldest release we found (so 2.0.0.dev0 in this case).

Undoubtedly some of our problem here comes from the fact that Version doesn't accurately implement https://peps.python.org/pep-0440/; to repeat my mantra from elsewhere, "it sure would be nice if we could just rely on packaging" and in this case just use packaging.version.Version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230903/3fa33d3c/attachment-0001.htm>