[Webkit-unassigned] [Bug 260721] Refactor compare-results to have more consistent style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 1 13:41:20 PDT 2023


hysu <hysu at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |hysu at apple.com

--- Comment #2 from hysu <hysu at apple.com> ---
On further thought, it's probably not the best idea to do style cleanup for the sake of style cleanup in this case, since it'll obfuscate the change history quite a bit and may break other scripts that depend on these functions. For example, I think renaming all the functions to not be camelcase just for the sake of being good Pythonic style is probably not the thing to do here.

Though, I think there is a value to combining duplicated logic and auditing it to make sure that everything we expect to run is running - but at that point, it's not really a style change patch anymore.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230901/b7e17631/attachment.htm>

More information about the webkit-unassigned mailing list