[Webkit-unassigned] [Bug 262718] New: Introduce 'rotateRadians' helper function and use across WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 12:39:09 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=262718

            Bug ID: 262718
           Summary: Introduce 'rotateRadians' helper function and use
                    across WebKit
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com

Hi Team,

While going through Blink commits, I came across a helper, which reduces few multiplication etc.

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=167603 (Helper function) and https://src.chromium.org/viewvc/blink?revision=168929&view=revision (Use in Canvas etc.)

___

If we add new rotateRadians function, we will be able to reduce unnecessary operations.

 Before : rad -> rad2deg -> deg2rad -> calc sinNcos
 After  : rad                       -> calc sinNcos

As a result, we can reduce two multiplication and two division.

___

It benefits by doing above.

So just wanted to raise, so I can do PR.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231005/5692fc77/attachment-0001.htm>


More information about the webkit-unassigned mailing list