[Webkit-unassigned] [Bug 265619] New: Extend 'Presentational Hints' from 'LI' (list-item) to 'OL'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=265619

            Bug ID: 265619
           Summary: Extend 'Presentational Hints' from 'LI' (list-item) to
                    'OL'
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: WPTImpact
          Severity: Normal
          Priority: P2
         Component: DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: annevk at annevk.nl, ntim at apple.com

Hi Team,

While exploring failures which are not related to 'counter-rest' etc. in following WPT Testcase:

WPT Testcase: https://wpt.fyi/results/html/rendering/non-replaced-elements/lists/lists-styles.html?label=master&label=experimental&aligned&q=safari%3Afail

We fail following tests:

<ol type="none"> - list-style-type      
<ol type="NONE"> - list-style-type      
<ol type="disc"> - list-style-type      
<ol type="DISC"> - list-style-type      
<ol type="circle"> - list-style-type    
<ol type="CIRCLE"> - list-style-type    
etc.

I looked into Web-Spec and came across following: https://html.spec.whatwg.org/#lists & https://drafts.csswg.org/css-lists/#ua-stylesheet

In following, I noticed that (in HTML Spec), we have presentational hints for 'LI' but not for 'OL':

ul[type=none i], li[type=none i] { list-style-type: none; }
ul[type=disc i], li[type=disc i] { list-style-type: disc; }
ul[type=circle i], li[type=circle i] { list-style-type: circle; }
ul[type=square i], li[type=square i] { list-style-type: square; }

___

Now when I looked into 'HTMLOListElement::collectPresentationalHintsForAttribute', I noticed that we don't account for failing test related presentational hints and when I update similar to 'HTMLLIElement'. We do progress all above failing tests.


I just wanted to check whether I should do PR to fix the bug or we wait for 'Web Spec' to reflect this?

CCing - Anne & Tim - for their input. If I came to wrong conclusion, it is still fine, it would be good to learn something from this bug for me.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231201/32fb23f4/attachment.htm>