[Webkit-unassigned] [Bug 265149] New: Use 'rotateRadians' in CanvasRenderingContext2DBase.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 20 09:53:12 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=265149

            Bug ID: 265149
           Summary: Use 'rotateRadians' in
                    CanvasRenderingContext2DBase.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Canvas
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: dino at apple.com

Hi Team,

We merged Blink's patch to have 'rotateRadians' rather than multiple conversions, we can use it here as well:

https://searchfox.org/wubkat/source/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp#784

^ From 'newTransform.rotate(angleInRadians / piDouble * 180.0);' to 'newTransform.rotateRadians(angleInRadians);'

https://searchfox.org/wubkat/source/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp#792

^ From 'm_path.transform(AffineTransform().rotate(-angleInRadians / piDouble * 180.0));' to 'm_path.transform(AffineTransform().rotateRadians(-angleInRadians));'

It is just to use the function more and more.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231120/b19e1395/attachment.htm>


More information about the webkit-unassigned mailing list