[Webkit-unassigned] [Bug 265101] New: Make a couple more http/tests/security tests use window.internals.isFullyActive(Document&)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 18 18:56:17 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=265101

            Bug ID: 265101
           Summary: Make a couple more http/tests/security tests use
                    window.internals.isFullyActive(Document&)
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mike at w3.org

https://commits.webkit.org/270737@main added a new window.internals.isFullyActive(Document&) function — intended for tests where it’s necessary to ensure whether or not a particular document is fully active — and used that function to update (fix) the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test, which had been flaky since it was last updated in https://commits.webkit.org/269235@main.

And in that https://commits.webkit.org/269235@main change which caused the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test to become flaky, its companion tests at LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html and LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html had also been updated in the same way as the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html had been before it was subsequently fixed.

And while those two other companion tests have not yet been flaky, we should also (re)update them to now use window.internals.isFullyActive(Document&) — in order to ensure they’re actually testing what they’re intended to be testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231119/00f834fd/attachment.htm>


More information about the webkit-unassigned mailing list