[Webkit-unassigned] [Bug 264145] New: collectLayerFragments() expects a dirty rect relative to the multicol container.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=264145

            Bug ID: 264145
           Summary: collectLayerFragments() expects a dirty rect relative
                    to the multicol container.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While going through Blink's Commits, I came across another failing test case for Multicolumn content being RTL.

Test Case: https://jsfiddle.net/e15f4a9p/show

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/3abc8fcb44ca7a3a31f37790929808c62aec931f

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFragmentedFlow.cpp#888

I tried following:

void RenderFragmentedFlow::collectLayerFragments(LayerFragments& layerFragments, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRectInFragmentedFlow)
{
    ASSERT(!m_fragmentsInvalidated);

    LayoutRect enclosingFragmentedFlow(dirtyRectInFragmentedFlow);
    enclosingFragmentedFlow.moveBy(location());
    for (auto& fragment : m_fragmentList)
        fragment.collectLayerFragments(layerFragments, layerBoundingBox, enclosingFragmentedFlow);
}

and

void RenderFragmentedFlow::collectLayerFragments(LayerFragments& layerFragments, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect)
{
    ASSERT(!m_fragmentsInvalidated);

    LayoutRect dirtyRectInFragmentedFlow(dirtyRect);
    dirtyRectInFragmentedFlow.moveBy(location());
    for (auto& fragment : m_fragmentList)
        fragment.collectLayerFragments(layerFragments, layerBoundingBox, dirtyRectInFragmentedFlow);
}

with corresponding change in .h file as well but it does not make it progress.

____

Just wanted to raise so we can fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231103/5dd57cfd/attachment.htm>