[Webkit-unassigned] [Bug 264130] New: GlyphData.isValid() audit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=264130

            Bug ID: 264130
           Summary: GlyphData.isValid() audit
           Product: WebKit
           Version: Safari 17
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Text
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fantasai.bugs at inkedblade.net
                CC: mmaxfield at apple.com, vitor.roriz at apple.com

I'm reviewing some code and noticed that some places use GlyphData.isValid() and other places use GlyphData.glyph and other places use GlyphData.font to check whether the GlyphData is valid or not.

We should probably be consistent, and probably use .isValid().

See https://github.com/WebKit/WebKit/commit/4535075b56fdb33a076f51fe92cd0bb8832797c8 and https://github.com/WebKit/WebKit/commit/ac25c7819037b1df2d448fca20dbfba7f96ca69c

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231103/fef4d90e/attachment.htm>