[Webkit-unassigned] [Bug 257196] New: HTMLOptionElement text is impacted by 'Backslash-as-JPY' hack

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 23 05:32:00 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=257196

            Bug ID: 257196
           Summary: HTMLOptionElement text is impacted by
                    'Backslash-as-JPY' hack
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: Forms
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: akeerthi at apple.com, annevk at annevk.nl,
                    cdumez at apple.com, karlcow at apple.com,
                    wenson_hsieh at apple.com

Hi Team,

WebKit has 'Backslash-as-JPY' hack and it was removed from Blink.

I noticed that we have 'WPT' test, which fail due to this hack:

WPT Test Link: https://wpt.fyi/results/html/semantics/forms/the-option-element/option-text-backslash.html?label=master&label=experimental&aligned&q=option-text-backslash.html

WPT Test Live Link: http://wpt.live/html/semantics/forms/the-option-element/option-text-backslash.html

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=159589

^ Only doing partial merge of above to HTMLOptionElement (I also did for HTMLOptGroupElement).

We pass the above testcase.

____

Changes in HTMLOptGroupElement.cpp (Line 121 onward):

String HTMLOptGroupElement::groupLabelText() const
{
    String itemText = attributeWithoutSynchronization(labelAttr);

    // In WinIE, leading and trailing whitespace is ignored in options and optgroups. We match this behavior.

______

Changes in HTMLOptionElement.cpp (Line 108 onward):

String HTMLOptGroupElement::groupLabelText() const
{
    String itemText = attributeWithoutSynchronization(labelAttr);

    // In WinIE, leading and trailing whitespace is ignored in options and optgroups. We match this behavior.

______

Just wanted to raise so we can track it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230523/912c2cc6/attachment.htm>


More information about the webkit-unassigned mailing list