[Webkit-unassigned] [Bug 257172] New: HTMLOptionElement text setter should not throw
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 22 17:21:23 PDT 2023
https://bugs.webkit.org/show_bug.cgi?id=257172
Bug ID: 257172
Summary: HTMLOptionElement text setter should not throw
Product: WebKit
Version: Safari Technology Preview
Hardware: Unspecified
OS: Unspecified
Status: NEW
Keywords: BrowserCompat, WPTImpact
Severity: Normal
Priority: P2
Component: Forms
Assignee: webkit-unassigned at lists.webkit.org
Reporter: ahmad.saleem792 at gmail.com
CC: akeerthi at apple.com, annevk at annevk.nl,
cdumez at apple.com, rniwa at webkit.org,
wenson_hsieh at apple.com
Hi Team,
This is another WPT Test case progression:
WPT Test Case - https://wpt.fyi/results/html/semantics/forms/the-option-element/option-text-setter.html?label=master&label=experimental&aligned&q=forms
WPT Test Case Link - http://wpt.live/html/semantics/forms/the-option-element/option-text-setter.html
Blink Commit - https://chromium-review.googlesource.com/c/chromium/src/+/721610
WebKit Source (only need to changes in HTMLOptionElement.cpp):
Delete from L126 to L133 - https://github.com/WebKit/WebKit/blob/21a4b1c5559f6ddda3f3c4166e5ab33cab2c475d/Source/WebCore/html/HTMLOptionElement.cpp#L126
and then add this line:
setTextContent(WTFMove(text));
______
This will fix another failing WPT test case and matching Chromium and Web-Spec:
Web-Spec: https://html.spec.whatwg.org/#dom-option-text
"The text attribute's setter must string replace all with the given value within this element.."
Chrome / Blink mention this spec line:
"On setting, the text attribute must act as if the textContent IDL
attribute on the element had been set to the new value"
Which I was not able to find.
____
Just wanted to raise.
Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230523/91f2a635/attachment.htm>
More information about the webkit-unassigned
mailing list