[Webkit-unassigned] [Bug 167111] <summary> does not respect display: flex

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167111

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmad.saleem792 at gmail.com,
                   |                            |akeerthi at apple.com,
                   |                            |rniwa at webkit.org

--- Comment #4 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
I tried similar to Blink:

https://chromium.googlesource.com/chromium/src.git/+/b711bbea21e196179a525c1588004ca4f60d025d

______

RenderPtr<RenderElement> HTMLSummaryElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
{
    // <summary> elements with display:list-item should not be rendered as list items because they'd end up with two markers before the text (one from summary element and the other as a list item).
    DisplayType display = style.display();
    if (display == DisplayType::Flex || display == DisplayType::Grid || display == DisplayType::InlineFlex || display == DisplayType::InlineGrid)
        return RenderElement::createFor(*this, WTFMove(style));
    return RenderElement::createFor(*this, WTFMove(style), { RenderElement::ConstructBlockLevelRendererFor::ListItem, RenderElement::ConstructBlockLevelRendererFor::Inline, RenderElement::ConstructBlockLevelRendererFor::TableOrTablePart });
}

_____

Although above didn't work. It compiles but no progression.

@Aditya, @Ryosuke - any tip or help?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230520/932f96d9/attachment-0001.htm>