[Webkit-unassigned] [Bug 256811] New: textareas logical height with overflow auto shouldn't add scrollbar-thickness

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 15 15:18:20 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=256811

            Bug ID: 256811
           Summary: textareas logical height with overflow auto shouldn't
                    add scrollbar-thickness
           Product: WebKit
           Version: Safari 16
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: luke at warlow.dev
                CC: cdumez at apple.com, wenson_hsieh at apple.com

Currently in WebKit if a textarea has overflow auto and overflow-wrap normal, it includes the scrollbar thickness in the logical height. This check doesn't exist in Firefox and no longer exists in Chrome as of https://chromium.googlesource.com/chromium/src/+/18481ffa332076e58fd9adbbea2062c2ba087dfb

It would be good to remove it from WebKit too for interop purposes.


if ((isHorizontalWritingMode() && (style().overflowX() == Overflow::Scroll ||  (style().overflowX() == Overflow::Auto && innerText->renderer()->style().overflowWrap() == OverflowWrap::Normal)))
    || (!isHorizontalWritingMode() && (style().overflowY() == Overflow::Scroll ||  (style().overflowY() == Overflow::Auto && innerText->renderer()->style().overflowWrap() == OverflowWrap::Normal))))
    logicalHeight += scrollbarThickness();

The above code inside of RenderTextControl.cpp would become something like the below code:

if ((isHorizontalWritingMode() && style().overflowX() == Overflow::Scroll)
    || (!isHorizontalWritingMode() && style().overflowY() == Overflow::Scroll))
    logicalHeight += scrollbarThickness();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230515/4d054199/attachment.htm>


More information about the webkit-unassigned mailing list