[Webkit-unassigned] [Bug 249930] Don't add empty rects during addFocusRingRects in RenderInline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=249930

--- Comment #6 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to zalan from comment #5)
> (In reply to Ahmad Saleem from comment #2)
> > Created attachment 466314 [details]
> > GitHub Patch
> > 
> > I manage to do merge and compile this but I think Line 930 is problematic
> > since it does not fix the failing test case, which I have attached here on
> > local build.
> > 
> > Just wanted to share what works so if anyone can highlight mistake, I can
> > fix it or if they can fix it, they can take it up.
> WebKit has addRect() and not operator(). just replace it and it will start
> working.

Worked!!! (Test case also fixed - test in Minibrowser). Going to draft PR first and once I will fix all bugs, I will do ask for review. :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230513/204f7a8e/attachment.htm>