[Webkit-unassigned] [Bug 256404] Document leak on pages with text input forms such as google.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=256404

--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
> That would mean the user won't be able to undo/redo edits once navigation happens forward or backward. I'm not certain that would be acceptable. At least in the case the page is put into back forward cache, we should probably hold onto those undo stack items.

Oh, that's a good point — we should definitely avoid removing items from the undo stack in that case. I wonder if we need a mechanism to purge a subset of items from the undo stack only when the associated page is ejected from the cache?

(In reply to Chris Dumez from comment #11)
> (In reply to Chris Dumez from comment #10)
> > Cannot EditCommandComposition old a WeakPtr to the Document instead of a
> > RefPtr to break the cycle?
> 
> old -> hold

I think the issue with this is that `EditCommandComposition` needs to hold arbitrary (possibly disconnected) nodes, which will strongly reference the document. Making these node references weak would break undo/redo for some editing operations that replace nodes, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230510/a1801bd0/attachment.htm>