[Webkit-unassigned] [Bug 256555] New: [browserperfdash-benchmark] Support supplying browser arguments on linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=256555

            Bug ID: 256555
           Summary: [browserperfdash-benchmark] Support supplying browser
                    arguments on linux
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: spectranaut at igalia.com

Support for browser arguments was added to run-benchmark in this commit: https://github.com/WebKit/WebKit/commit/fa4a5245bfbbbbd12c6fd9fea70b4efc83f2023a

But only for mac environments!

I'd like linux support, allowing:
```
./run-benchmark  --plan webkitpy/benchmark_runner/data/plans/jetstream.plan --platform linux --browser chrome --browser-args --force-device-scale-factor=.75 --incognito
```

Where `--force-device-scale-factor=.75` and `--incognito` are passed through to the browser.


Also I'd like to be able to use the same argument in the wrapper `browserperfdash-benchmark`. Essentially allowing the following:

```
Tools/Scripts/browserperfdash-benchmark --browser chrome --browser-version 111111 --timestamp 12345 --plan jetstream --config-file /home/spectranaut/chromium-perf-bot/custom/fake_config.txt --browser-args --force-device-scale-factor=.75 --incognito
```

I have a patch for this that I have been using locally. To do this on linux I had to change "browser_args" from a positional to a not-positional argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230509/27f041f6/attachment.htm>