[Webkit-unassigned] [Bug 256438] New: Stop using RetainPtr<>::autorelease() in createNSArray() lambda

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=256438

            Bug ID: 256438
           Summary: Stop using RetainPtr<>::autorelease() in
                    createNSArray() lambda
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
        Depends on: 233350

Stop using RetainPtr<>::autorelease() in createNSArray() lambda.

This is not necessary:

- (NSArray<_WKApplicationManifestIcon *> *)icons
{
    return createNSArray(_applicationManifest->applicationManifest().icons, [] (auto& coreIcon) -> id {
        return adoptNS([[_WKApplicationManifestIcon alloc] initWithCoreIcon:&coreIcon]).autorelease();
    }).autorelease();
}

in Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm.

Regressed in:

    Add support for web app manifest icons in WebKit/UI Process layer
    <https://bugs.webkit.org/show_bug.cgi?id=233350>
    <rdar://problem/84311569>
    <https://commits.webkit.org/244460@main>


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=233350
[Bug 233350] Add support for web app manifest icons in WebKit/UI Process layer
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230508/839d979e/attachment.htm>