[Webkit-unassigned] [Bug 254697] New: Fix operator precedence in SizesCalcParser.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=254697

            Bug ID: 254697
           Summary: Fix operator precedence in SizesCalcParser.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: koivisto at iki.fi, simon.fraser at apple.com

Hi Team,

While going through Blink's commit, I came across another potential merge and it seems to compile and work.

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/e0bcd910832c55445bc6bb4156acd716e0667248

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/css/parser/SizesCalcParser.cpp#65

Just wanted to raise to get confirmation, if this need to be fixed.

It compiles locally (without comments) from Line 72-91:

    bool incomingOperatorPriority;

    if (!operatorPriority(token.delimiter(), incomingOperatorPriority))
        return false;

    while (!stack.isEmpty()) {
        const auto& topOfStack = stack.last();
        if (topOfStack.type() != DelimiterToken)
            break;
        bool stackOperatorPriority;
        if (!operatorPriority(topOfStack.delimiter(), stackOperatorPriority))
            return false;
    if (incomingOperatorPriority && !stackOperatorPriority)
        break;
        appendOperator(topOfStack);
        stack.removeLast();
    }
    stack.append(token);
    return true;
}

________

Appreciate if someone can confirm, I am happy to run it via EWS to see, if it works.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230329/1c1af2ae/attachment.htm>