[Webkit-unassigned] [Bug 254376] New: Random fixes from CPPChecker done in Blink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=254376

            Bug ID: 254376
           Summary: Random fixes from CPPChecker done in Blink
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: sabouhallawa at apple.com, simon.fraser at apple.com,
                    zimmermann at kde.org

Hi Team,

While going through Blink's commit, I came across following fixes identified by CPPChecker and done by Blink.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=165481

There are some which we can import or merge, just raising to get input.

Similar to this was delete: https://searchfox.org/wubkat/source/Source/WebCore/rendering/style/RenderStyle.h#416

Deleted - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/LegacyRenderSVGShape.h#134 but we have three uses of it.

This can be done safely - tried it in Local Build as well - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGTextQuery.cpp#198

While all others were ++it changing to it++ and changing == to !, which our style checker already take care of.

I think from above, we can merge 'SVGTextQuery' only but just wanted to get input.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230323/cde6f3ee/attachment-0001.htm>