[Webkit-unassigned] [Bug 254183] Let siblings layout if an adjacent float may no longer affect them

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=254183

--- Comment #1 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #0)
> Hi Team,
> 
> While going through Blink's commit, I came across another potential merge
> and bug fix.
> 
> Blink Commit -
> https://chromium.googlesource.com/chromium/src.git/+/
> 789b5e528fb3bd9ca44341de46547c45355652ab
> 
> Test Case - https://jsfiddle.net/kqj93hp5/show
> 
> ^ Failing in Safari Technology Preview 165, passes after adding following in
> WebKit Source:
> 
>         fb = std::max(fb, childBlockFlow->lowestFloatLogicalBottom());
> 
> In WebKit Source after this as L969:
> 
> https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.
> cpp#968
> 
> Just wanted to raise so we can fix it.
> 
> Thanks!

Merging this as it is, led to crashes in my local build (It happened when I try to looked into old bugs with 'negative margin' reference to see, if they are now fixed with this or not.

Additionally, then I took the patch reference to search whether there is any follow-up on Chromium / Blink and noticed that it had regression in performance test and got superseded by this:

https://chromium.googlesource.com/chromium/src.git/+/4a961b8eca27af4108358a30753197754316524b

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230320/caa144aa/attachment.htm>