[Webkit-unassigned] [Bug 253814] Concat with a CSSStyleSheet and shadowRoot.adoptedStyleSheets returns array in array

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 13 07:45:36 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=253814

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #2)
> (In reply to Chris Dumez from comment #1)
> > Question for JSC people (added in cc). Do you know what I need to do in
> > order to make concat() behave correctly with this new IDL type?
> 
> The type of adoptedStyleSheets is a JSC::JSObservableArray, which is a
> subclass of JSC::JSArray.

Looks like concat relies on isJSArray():

inline bool isJSArray(JSCell* cell)
{
    ASSERT((cell->classInfo() == JSArray::info()) == (cell->type() == ArrayType));
    return cell->type() == ArrayType;
}

So `cell->type() == ArrayType` is likely false for JSC::JSObservableArray.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230313/12d11fa7/attachment.htm>


More information about the webkit-unassigned mailing list