[Webkit-unassigned] [Bug 253771] New: Delete odd assignment of IgnoreOverlayScrollbarSize

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=253771

            Bug ID: 253771
           Summary: Delete odd assignment of IgnoreOverlayScrollbarSize
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While going through Blink's commit, I came across another potential merge and I have tested this locally on --release build and does not seem to cause any issue. Although EWS or Debug builds might have other story to tell.

NOTE - Motivation to merge is to get rid of "FIXME" and deadcode is deadcode:

____

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/bd25c52a9a4dcd09e0ed47ba300cf82e86b28cb7

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayer.cpp#4480

^ Removed:


            ClipRectsContext parentContext(clipRectsContext);
            parentContext.options.remove(ClipRectsOption::IncludeOverlayScrollbarSize); // FIXME: Why?

            if ((parentContext.clipRectsType != TemporaryClipRects && parentContext.clipRectsType != AbsoluteClipRects) && clipCrossesPaintingBoundary())
                parentContext.clipRectsType = TemporaryClipRects;

_____

Replaced:

parentLayer->calculateClipRects(parentContext, clipRects);

with

parentLayer->calculateClipRects(clipRectsContext, clipRects);

____

Just wanted to raise to get input.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230312/8cf5fb81/attachment.htm>