[Webkit-unassigned] [Bug 253749] github.com is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=253749

Xi Ruoyao <xry111 at xry111.site> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xry111 at xry111.site

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org
            Summary|[GTK] github.com is broken  |github.com is broken
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Xi Ruoyao <xry111 at xry111.site> ---
I've reported https://github.com/orgs/community/discussions/49755.

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Time for a mandatory break from WebKit development. :P Cannot view that discussion or any pull requests.

Interestingly, it does work if I use Epiphany 43 with WebKitGTK 2.38 for whatever reason, so I can see the problem is we're missing navigator.clipboard.read.

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #2)
> Interestingly, it does work if I use Epiphany 43 with WebKitGTK 2.38 for
> whatever reason

Ah no, I just got unlucky. It's broken in both versions but sometimes the page content displays anyway.

--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
This is the missing API:

# FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should consider turning it on for WebKitLegacy as well.
AsyncClipboardAPIEnabled:
  type: bool
  status: mature
  humanReadableName: "Async clipboard API"
  humanReadableDescription: "Enable the async clipboard API"
  defaultValue:
    WebKitLegacy:
      default: false
    WebKit:
      "PLATFORM(COCOA)" : true
      default: false
    WebCore:
      default: false

I'm surprised this sort of breakage does not happen more often since we're not very good at keeping up with new web APIs.

It looks like the implementation in Source/WebCore/Modules/async-clipboard is entirely cross-platform (build on top of our existing clipboard platform abstractions) and the only platform-specific bits are the image reader, so... maybe we can just turn it on.

--- Comment #5 from Xi Ruoyao <xry111 at xry111.site> ---
(In reply to Michael Catanzaro from comment #4)
> This is the missing API:
> 
> # FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should
> consider turning it on for WebKitLegacy as well.
> AsyncClipboardAPIEnabled:
>   type: bool
>   status: mature
>   humanReadableName: "Async clipboard API"
>   humanReadableDescription: "Enable the async clipboard API"
>   defaultValue:
>     WebKitLegacy:
>       default: false
>     WebKit:
>       "PLATFORM(COCOA)" : true
>       default: false
>     WebCore:
>       default: false
> 
> I'm surprised this sort of breakage does not happen more often since we're
> not very good at keeping up with new web APIs.
> 
> It looks like the implementation in Source/WebCore/Modules/async-clipboard
> is entirely cross-platform (build on top of our existing clipboard platform
> abstractions) and the only platform-specific bits are the image reader,
> so... maybe we can just turn it on.

Even if we don't turn it on, I think GitHub developers should not make a dead loop in the JavaScript code...

--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---


*** This bug has been marked as a duplicate of bug 211979 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230311/ad13254e/attachment.htm>