[Webkit-unassigned] [Bug 253403] New: Remove deadcode from SVGResourcesCache::clientStyleChanged

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 4 18:18:58 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=253403

            Bug ID: 253403
           Summary: Remove deadcode from
                    SVGResourcesCache::clientStyleChanged
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: sabouhallawa at apple.com, simon.fraser at apple.com,
                    zimmermann at kde.org

Hi Team,

While going through Blink's commits, I came across another potential merge:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/3dbb235c9806036ecd531aa4eeae7ed1c4be89a7

WebKit Source Code - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGResourcesCache.cpp#169

^ Remove this IF condition and add these ASSERT at start of function:


    ASSERT(renderer);
    ASSERT(renderer.element());
    ASSERT(renderer.element()->isSVGElement());

_____

Just wanted to raise to get insight.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230305/169cd217/attachment.htm>


More information about the webkit-unassigned mailing list