[Webkit-unassigned] [Bug 253272] New: s_maxSize should be 'unsigned' rather than 'int' in WidthCache.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=253272

            Bug ID: 253272
           Summary: s_maxSize should be 'unsigned' rather than 'int' in
                    WidthCache.h
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: ap at webkit.org, bfulgham at webkit.org, ntim at apple.com,
                    simon.fraser at apple.com, zalan at apple.com

Hi Team,

I noticed that 's_maxSize' is int and it means that it can be negative while I think cache should be 0 or positive for which we should have it as 'unsigned'.

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/WidthCache.h#217

static const int s_maxSize = 500000;

Appreciate if someone can confirm my understanding and I am happy to do PR to fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230302/0e9109cd/attachment.htm>