[Webkit-unassigned] [Bug 250681] REGRESSION(257865 at main): B3Validate.cpp: fix !ENABLE(WEBASSEMBLY_B3JIT)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250681

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org,
                   |                            |ysuzuki at apple.com,
                   |                            |zdobersek at igalia.com

--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
I did not know about https://github.com/WebKit/WebKit/pull/8696 because this bug did not contain any link to it!

(In reply to Justin Michaud from comment #2)
> I think that enabling WebAssembly but not having ENABLE_WEBASSEMBLY_B3JIT is
> a very unusual configuration, unsupported by any other platform.

I see Yusuke says, from https://github.com/WebKit/WebKit/pull/8696: "If B3 is compiled, WEBASSEMBLY_B3JIT needs to be enabled." And B3 is a dependency of WebAssembly. I see the non-RISCV64 guards in PlatformEnable.h also attempt to enforce this dependency. So why are ENABLE_WEBASSEMBLY and ENABLE_WEBASSEMBLY_B3JIT separate flags, then? If this is all true, then we should surely get rid of ENABLE_WEBASSEMBLY_B3JIT, right?

Anyway, sounds like we'll need to revert the PlatformEnable.h changes from 255090 at main "[JSC] RISCV64 support for WebAssembly". Zan, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230302/acf9ad20/attachment.htm>