[Webkit-unassigned] [Bug 253198] New: Remove code in Editor::rangeOfString() that unnecessarily resets the searchRange after the first find operation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=253198

            Bug ID: 253198
           Summary: Remove code in Editor::rangeOfString() that
                    unnecessarily resets the searchRange after the first
                    find operation
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: rniwa at webkit.org, wenson_hsieh at apple.com

Hi Team,

I came across another dead-code removal from Blink's commit, which was added in WebKit with following commit:

WebKit Old Commit - http://trac.webkit.org/changeset/14782

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/857f2e42c139b277ed29cd8ae112cb4f1d6b5a90

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/editing/Editor.cpp#3615

Just wanted to raise a get input and also I tried building local build after deleting and it works but didn't run test suite.

Appreciate if someone can give go ahead or know history of it whether it is safe to remove in WebKit or not?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230301/5883be26/attachment.htm>