[Webkit-unassigned] [Bug 252758] REGRESSION(257865 at main): "B3Validate.cpp:455:43: error: ‘toB3Type’ was not declared in this scope" with ENABLE(WEBASSEMBLY_B3JIT) disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252758

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |justin_michaud at apple.com
            Summary|B3Validate.cpp:455:43:      |REGRESSION(257865 at main):
                   |error: ‘toB3Type’ was not   |"B3Validate.cpp:455:43:
                   |declared in this scope      |error: ‘toB3Type’ was not
                   |                            |declared in this scope"
                   |                            |with
                   |                            |ENABLE(WEBASSEMBLY_B3JIT)
                   |                            |disabled

--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Heinrich Schuchardt from comment #6)
> There is an inconsistency between
> 
> Source/JavaScriptCore/b3/B3Validate.cpp
> 
> which uses #if ENABLE(B3_JIT) and the included
> 
> Source/JavaScriptCore/wasm/WasmTypeDefinition.h
> 
> which depends on #if ENABLE(WEBASSEMBLY_B3JIT).
> 
> If B3_JIT cannot be used for webassembly on RISC-V, why is 
> Source/JavaScriptCore/b3/B3Validate.cpp compiled?

Well it's needed for ENABLE(B3_JIT), of course.

Looks like this broke in 257865 at main "[SIMD] B3/OMG Support" but I don't know what to do about it. Justin, can you take a look please? Is it safe to just add preprocessor guards around the code that you added?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230301/112812bf/attachment.htm>