[Webkit-unassigned] [Bug 258491] Flaky background-position test and on window resize fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=258491

--- Comment #4 from zalan <zalan at apple.com> ---
(In reply to Ahmad Saleem from comment #0)
> Hi Team,
> 
> While going through some Blink merge, I noticed that my patch affected below
> three tests, while investigating, I noticed that we 'PASS' them but upon
> checking, noticed that if we resize the browser, it start showing 'red'
> strip, which means, we fail later on resize.
> 
> https://wpt.fyi/results/css/css-writing-
> modes?label=master&label=experimental&aligned&q=background-position-vrl-0
> 
> Live Test Line (Sample):
> http://wpt.live/css/css-writing-modes/background-position-vrl-020.xht
> 
> ^ Open this in Safari Technology Preview 172 and resize browser window, we
> will now have 'red' strip.
> 
> __________
> 
> I did this patch here:
> 
> Link:
> https://github.com/WebKit/WebKit/blob/
> d5918187d18a309512bf04da9a709f43762634a0/Source/WebCore/rendering/
> BackgroundPainter.cpp#L554
> 
> LayoutRect extendedBackgroundRect =
> view.frameView().extendedBackgroundRectForPainting();
> +                if (renderer.style().writingMode() ==
> WritingMode::RightToLeft)
> +                   left = borderBoxRect.width() -
> positioningAreaSize.width() - right - renderer.marginRight();
> +               else
> 
> __________
> 
> Blink Commit:
> https://src.chromium.org/viewvc/blink?view=revision&revision=194132
> 
> ________
> 
> Just wanted to raise, so we can track these failures.
> 
> Thanks!
The second case fails with Chrome too so I assume the fix is not sufficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230630/fc978fd0/attachment.htm>