[Webkit-unassigned] [Bug 258254] document.execCommand('insertOrderedList'); can hang browser on removing list

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 26 13:50:07 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=258254

--- Comment #4 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #3)
> Change in 'Source/WebCore/editing/Editing.cpp' and following function
> 'firstEditablePositionAfterPositionInRoot':
> 
> From Line 271 onward:
> 
> Node* nonEditableNode = nullptr;
>     while (candidate.deprecatedNode() && !isEditablePosition(candidate) &&
> candidate.deprecatedNode()->isDescendantOf(*highestRoot)) {
>         nonEditableNode = candidate.deprecatedNode();
>         candidate = isAtomicNode(candidate.deprecatedNode()) ?
> positionInParentAfterNode(candidate.deprecatedNode()) :
> nextVisuallyDistinctCandidate(candidate);
>     }
>     if (candidate.deprecatedNode() && candidate.deprecatedNode() !=
> highestRoot && !candidate.deprecatedNode()->isDescendantOf(*highestRoot))
>         return { };
>     if (nonEditableNode &&
> nonEditableNode->isDescendantOf(candidate.deprecatedNode()))
>         candidate = nextVisuallyDistinctCandidate(candidate);
>     return candidate;
> }

This fixes hanging test case but the problem is that the test case uses 'assert_selection.js' and does not produce 'passing' test output. :-(

Something is wrong with 'assert_selection.js' while using in WebKit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230626/73064257/attachment.htm>


More information about the webkit-unassigned mailing list