[Webkit-unassigned] [Bug 258528] New: Rename 'assert-selection.js' to 'assert_selection.js' due to reliance on exact script name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=258528

            Bug ID: 258528
           Summary: Rename 'assert-selection.js' to 'assert_selection.js'
                    due to reliance on exact script name
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: rniwa at webkit.org

Hi Team,

It is very clear bug and it is to update test expectation, where we get error in test script:

https://github.com/WebKit/WebKit/blob/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1/LayoutTests/editing/inserting/insert-space-expected.txt#L4

--> It shows error here: resources/assert-selection.js:939:30

If I look at code: https://github.com/WebKit/WebKit/blob/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1/LayoutTests/resources/assert-selection.js#L938

It relies on 'assert_selection.js' rather my name of 'assert-selection.js' (which I kept to make it consistent with WebKit test naming and scripts name.

I think it would be difficult to maintain in future to make this 'script name' change always, so I will just make script name consistent. So it is easier to always use up-to-date script from Chromium.

Just raising this bug for that purpose.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230626/d73c3d4e/attachment-0001.htm>