[Webkit-unassigned] [Bug 258372] New: Ensure that percent height children use right value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=258372

            Bug ID: 258372
           Summary: Ensure that percent height children use right value
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
               URL: http://wpt.live/css/css-transforms/transform-transform
                    ed-tr-percent-height-child.html
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While looking for failing WPT tests from Interop 2021, I came across following failing test (in URL field) and noticed, it was fixed by following Blink Commit:

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/420ffd70631b3694288f1d9999e1b01a8fabbfca

When applying similar in WebKit Source: https://github.com/WebKit/WebKit/blob/d192a99af4640e4cd76b5429214f29252f2fa590/Source/WebCore/rendering/RenderBox.cpp#L3835

Changing from:

const RenderBlock& cb = is<RenderBlock>(containingBlock) ? downcast<RenderBlock>(containingBlock) : *containingBlock.containingBlock();

to:

const RenderBox& cb = downcast<RenderBox>(containingBlock);

Fix the failing test similar to Blink.

_____________

any input or approach concern, or I can do PR?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230621/c9cf986b/attachment.htm>