[Webkit-unassigned] [Bug 256895] TestExpectations should support some form of inheritance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 16 10:46:30 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=256895

Sam Sneddon [:gsnedders] <gsnedders at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Dawn_Flores at apple.com,
                   |                            |jenner at apple.com

--- Comment #4 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
(In reply to Fujii Hironori from comment #1)
> How about this case?
> 
> editing/mac [ Pass ]
> editing/mac/dictionary-lookup/dictionary-lookup-input.html [ Crash ]
> 
> Pass won't be inherited?

The problem here is we have a number of different things we put in TestExpectations; some of these—the actual expectations—are mutually exclusive ( Pass / Failure / Crash / Timeout / etc.), but some of these are modifiers that adjust how (or if) the test is run: Skip / WontFix / Slow / DumpJSConsoleLogInStdErr / Rebaseline.

At least to me, it seems sensible to allow the modifiers to be inherited separately to the expectations, though I believe we also rely on them _not_ being inherited today (Pass overriding Skip, for example).

If we _do_ inherit modifiers separately we probably need some way to negate them and go back to the default state.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230616/6a04d37f/attachment.htm>


More information about the webkit-unassigned mailing list