[Webkit-unassigned] [Bug 244357] overflow overlay missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244357

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmad.saleem792 at gmail.com

--- Comment #12 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Do we need to do anything after bug 189811?

_________

Although, if needed or we are missing any piece, we can do this:

In 'RenderStyleConstants.h', we add 'Overlay':

https://searchfox.org/wubkat/source/Source/WebCore/rendering/style/RenderStyleConstants.h#267

In 'RenderStyleConstants.cpp', we add 'Overlay' case in switch:

case Overflow::Overlay: ts << "overlay"; break;

^ https://searchfox.org/wubkat/source/Source/WebCore/rendering/style/RenderStyleConstants.cpp#747

In 'StyleAdjuster.cpp', we add following to make 'overlay' as alias of 'auto' similar to Gecko & Blink:

    if (style.overflowX() == Overflow::Overlay)
        style.setOverflowX(Overflow::Auto);
    if (style.overflowY() == Overflow::Overlay)
        style.setOverflowY(Overflow::Auto);

https://searchfox.org/wubkat/source/Source/WebCore/style/StyleAdjuster.cpp#504

^ here or nearby where it is appropriate.

In 'CSSPrimitiveValueMappings.h', add case for 'Overlay':

    case Overflow::Overlay:
        return CSSValueAuto;

https://searchfox.org/wubkat/source/Source/WebCore/css/CSSPrimitiveValueMappings.h#902

_______

Although, we are already passing below WPT test:

https://wpt.fyi/results/css/css-overflow/overflow-overlay.html?label=master&label=experimental&aligned=&q=overlay

_____

^ bug 189811 sufficient?

__________

Plus bug 243783 seems to be duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230615/e3ab6473/attachment-0001.htm>