[Webkit-unassigned] [Bug 258051] New: Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 13 16:28:36 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=258051

            Bug ID: 258051
           Summary: Stop autoreleasing WKWebView and WKContentView in
                    WebKit::PageClientImplIOS
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
        Depends on: 257938

Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS.

Since both m_webView and m_contentView are WeakObjCPtr<> instance variables, calling methods like `[m_webView bar]` results in autoreleasing `m_webView` every time.

Fix this by using convenience methods that call WeakObjCPtr<>::get() and return a RetainPtr<> instead.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=257938
[Bug 257938] Use smart pointers with PageLoadStateObserverBase subclasses and instance variables
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230613/b89a3027/attachment.htm>


More information about the webkit-unassigned mailing list