[Webkit-unassigned] [Bug 257867] Support custom annotations for Accessibility in composition contexts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=257867

Tyler Wilcock <tyler_w at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler_w at apple.com

--- Comment #7 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 466654
  --> https://bugs.webkit.org/attachment.cgi?id=466654
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466654&action=review

> Source/WebKit/UIProcess/mac/WebViewImpl.mm:5111
> +            auto it = annotations.find(key);
> +            if (it == annotations.end())
> +                it = annotations.add(key, Vector<CharacterRange> { }).iterator;

I think HashMap::ensure does this (find a value, initializing it if necessary). Might express the intent a bit better (if it works here).

> Source/WebKit/UIProcess/mac/WebViewImpl.mm:5150
>              underlines = compositionUnderlines(string);
> +        annotations = compositionAnnotations(string);

The indentation is different between these two lines. Not sure which is right, though.

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:669
> +            auto it = annotations.find(name);
> +            if (it == annotations.end())
> +                it = annotations.add(name, Vector<WebCore::CharacterRange> { }).iterator;

Another place where HashMap::ensure might work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230609/a50afc03/attachment.htm>