[Webkit-unassigned] [Bug 57178] InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 3 05:31:03 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=57178

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmad.saleem792 at gmail.com,
                   |                            |simon.fraser at apple.com,
                   |                            |zalan at apple.com

--- Comment #12 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Do we need to track this?

This is in Legacy Line Layout. Only following references exists in our code besides in 'LegacyInlineBox.cpp/h':

In RenderLineBreak:

isLastOnLine = !containingBlock->containingBlock()->inlineBoxWrapper()->nextOnLineExists();

isLastOnLine = !containingBlock->inlineBoxWrapper()->nextOnLineExists();

In RenderText:

isLastOnLine = !containingBlock->containingBlock()->inlineBoxWrapper()->nextOnLineExists();

isLastOnLine = !containingBlock->inlineBoxWrapper()->nextOnLineExists();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230603/f8704788/attachment-0001.htm>


More information about the webkit-unassigned mailing list