[Webkit-unassigned] [Bug 259254] Correctly identify overflow direction inside flexbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259254

--- Comment #6 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #5)
> NOTE - implementing this might progress more as well:
> https://chromium-review.googlesource.com/c/chromium/src/+/3686776

Based on this:

bool RenderFlexibleBox::isTopLayoutOverflowAllowed() const
{
    bool isWrapReverse = style().flexWrap() == FlexWrap::Reverse;
    if (isHorizontalWritingMode())
        return style().isColumnReverseFlexDirection() || (style().isRowFlexDirection() && isWrapReverse);
    return style().isLeftToRightDirection() == (style().isRowReverseFlexDirection() || (style().isColumnFlexDirection() && isWrapReverse));
}

bool RenderFlexibleBox::isLeftLayoutOverflowAllowed() const
{
    bool isWrapReverse = style().flexWrap() == FlexWrap::Reverse;
    if (isHorizontalWritingMode())
        return style().isLeftToRightDirection() == (style().isRowReverseFlexDirection() || (style().isColumnFlexDirection() && isWrapReverse));
    return style().isFlippedLinesWritingMode() == (style().isColumnReverseFlexDirection() || (style().isRowFlexDirection() && isWrapReverse));
}

and also necessary changes in RenderStyle.h and RenderStyleInlines.h, we progress following but fail two already passing as well:

>> css-flexbox/negative-overflow.html:

Pass now '.flexbox 5'.

>> negative-overflow-002.html:

Failures: .container 31, .container 32, .container 25 and .container 26

Passes: .container 16 & .container 17 and .container 69

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230731/290f405b/attachment.htm>