[Webkit-unassigned] [Bug 259254] Correctly identify overflow direction inside flexbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259254

--- Comment #4 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #3)
> I did wrong patch in Comment 0 but:
> 
> bool RenderFlexibleBox::isTopLayoutOverflowAllowed() const
> {
>     auto flexDirection = style().flexDirection();
>     if (isHorizontalWritingMode())
>         return flexDirection == FlexDirection::ColumnReverse;
>     return !style().isLeftToRightDirection() ^ (flexDirection ==
> FlexDirection::RowReverse);
> }
> 
> bool RenderFlexibleBox::isLeftLayoutOverflowAllowed() const
> {
>     auto flexDirection = style().flexDirection();
>     if (isHorizontalWritingMode())
>         return !style().isLeftToRightDirection() ^ (flexDirection ==
> FlexDirection::RowReverse);
>     return flexDirection == FlexDirection::ColumnReverse;
> }
> 
> ^ This make us progress on two subtests of
> 'css/css-flexbox/negative-overflow-002.html', for some reason of 'scrollbar'
> direction failure in 'overflow-top-left' seems to be 'scrollbar' related bug
> to me.

Precisely PASS .container 16 and PASS .container 17

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230731/0a6b74ff/attachment.htm>