[Webkit-unassigned] [Bug 259621] Potentially remove 'DarkGreyValue' from 'noshade' attribute of HTMLHRElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259621

--- Comment #3 from Tim Nguyen (:ntim) <ntim at apple.com> ---
(In reply to Ahmad Saleem from comment #2)
> We start failing this - https://jsfiddle.net/w589b0dh/show
> 
> As per spec, it is non-conforming standard with only support from Chrome and
> Safari only.
> 
> Spec:
> https://html.spec.whatwg.org/multipage/obsolete.html#non-conforming-features
> 
> Firefox Nightly fails a lot of tests from above.
> 
> Should we keep it or remove it altogether?
> 
> Or we can get rid of just this line:             
> 
> >> style.setProperty(CSSPropertyBorderColor, darkGrayValue.ptr());
> 
> 
> and still make us pass above test.

I would follow the spec here: https://html.spec.whatwg.org/#the-hr-element-2 . We deviate in multiple ways from the spec:

* background-color should not be set when setting the color / noshade attributes
* size attribute should set the border-width to the value divided by 2 when color/noshade is set, it should set the height otherwise.

More minor differences:
* width should parse dimensions, not integers
* size should parse non-negative integers, not all integers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230730/6689eff5/attachment.htm>