[Webkit-unassigned] [Bug 259621] New: Potentially remove 'DarkGreyValue' from 'noshade' attribute of HTMLHRElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259621

            Bug ID: 259621
           Summary: Potentially remove 'DarkGreyValue' from 'noshade'
                    attribute of HTMLHRElement
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: ntim at apple.com

Hi Team,

While going through 'HR' related failures on WPT, I just stumbled across following code:

case AttributeNames::noshadeAttr:
        if (!hasAttributeWithoutSynchronization(colorAttr)) {
            addPropertyToPresentationalHintStyle(style, CSSPropertyBorderStyle, CSSValueSolid);
            auto darkGrayValue = CSSValuePool::singleton().createColorValue(Color::darkGray);
            style.setProperty(CSSPropertyBorderColor, darkGrayValue.ptr());
            style.setProperty(CSSPropertyBackgroundColor, WTFMove(darkGrayValue));
        }

I noticed that we are assigning 'darkGrey' value using C++ but recently we added 'color' value from UA Stylesheet as below:

https://searchfox.org/wubkat/source/Source/WebCore/css/html.css#105

______

I looked into 'Firefox' to see if they have special color for 'noshade' attribute but they don't.

Test Case to check - https://www.quanzhanketang.com/tags/tryhtml_hr_noshade.html?filename=tryhtml_hr_noshade

____

I might be completely wrong but just wanted to raise this to check, whether we can get rid of this portion of code? [These lines]

            auto darkGrayValue = CSSValuePool::singleton().createColorValue(Color::darkGray);
            style.setProperty(CSSPropertyBorderColor, darkGrayValue.ptr());
            style.setProperty(CSSPropertyBackgroundColor, WTFMove(darkGrayValue));

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230729/211eef9c/attachment.htm>