[Webkit-unassigned] [Bug 259620] New: 'hr' with width as 0 or 0px get 1px leading to WPT failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259620

            Bug ID: 259620
           Summary: 'hr' with width as 0 or 0px get 1px leading to WPT
                    failure
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: WPTImpact
          Severity: Normal
          Priority: P2
         Component: DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: akeerthi at apple.com, karlcow at apple.com, ntim at apple.com,
                    rniwa at webkit.org

Hi Team,

While trying to investigate our WPT failures in HTML/Rendering for 'dimension-attributes.html', I came across following:

Test Case: http://wpt.live/html/rendering/dimension-attributes.html

For following two cases:

1) <hr width="0"> mapping to <hr> width property        
2) <hr width="0px"> mapping to <hr> width property      

We get 1px due to following:

https://github.com/WebKit/WebKit/blob/088b5a6b92a887bbf29d18135987d5c2c6392d20/Source/WebCore/html/HTMLHRElement.cpp#L89

Where we are forcing 1px:

addPropertyToPresentationalHintStyle(style, CSSPropertyWidth, 1, CSSUnitType::CSS_PX);

Changing it to '0' leads to two progressions.

Only Firefox passes these tests and Chrome Canary 117 also fail them.

______

I just wanted to raise and get input whether it is good to go so I can do PR or there are other consequences of this change.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230729/ef2cbea3/attachment.htm>