[Webkit-unassigned] [Bug 259581] New: Implement automatic text track selection for 'metadata' tracks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 27 16:52:15 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259581

            Bug ID: 259581
           Summary: Implement automatic text track selection for
                    'metadata' tracks
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
               URL: http://wpt.live/html/semantics/embedded-content/media-
                    elements/track/track-element/track-selection-metadata.
                    html
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com

Hi Team,

Going through WPT failures, came across following WPT test case failing:

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=189185

WPT: https://wpt.fyi/results/html/semantics/embedded-content/media-elements/track/track-element/track-selection-metadata.html?label=experimental&label=master&aligned=

Just raising so we can fix and align with spec.

_____

This below compiles and progresses following test:

void HTMLMediaElement::configureMetadataTextTrackGroup(const TrackGroup& group)
{
    ASSERT(group.tracks.size());
    // https://html.spec.whatwg.org/multipage/embedded-content.html#honor-user-preferences-for-automatic-text-track-selection
    // 3. If there are any text tracks in the media element's list of text tracks whose text track kind is
    // chapters or metadata that correspond to track elements with a default attribute set
    // whose text track mode is set to disabled, then set the text track mode of all such tracks to hidden.
    for (auto& textTrack : group.tracks) {
        if (textTrack->mode() != TextTrack::Mode::Disabled)
            continue;
        if (!textTrack->isDefault())
            continue;
        textTrack->setMode(TextTrack::Mode::Hidden);
    }
}

_______

Just wanted to raise so we can fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230727/0b6e56f0/attachment.htm>


More information about the webkit-unassigned mailing list