[Webkit-unassigned] [Bug 259562] New: REGRESSION(219104 at main): Broke --analyze and --coverage flags of build-jsc/build-webgpu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 27 08:37:55 PDT 2023


            Bug ID: 259562
           Summary: REGRESSION(219104 at main): Broke --analyze and
                    --coverage flags of build-jsc/build-webgpu
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at redhat.com

It looks like 219104 at main "build-jsc should invoke make instead of calling xcodebuild directly" broke the --analyze and --coverage options of build-jsc for Apple ports (and nowadays also build-webgpu since this code was moved from build-jsc to BuildSubproject.pm). (These options never worked for CMake ports.) When the flags are used, then additional XCode build options get added to @additionalSupportOptions, but this variable is no longer used anywhere. I don't know how to fix it.

Maybe the flags are not too valuable, since it took three years for us to notice, and I only noticed while trying to fix an unrelated bug (bug #259527). We should consider removing the flags. If we fix the flags instead of removing them, consider adjusting the help output to indicate they only work with XCode and not CMake.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230727/368e64d3/attachment.htm>

More information about the webkit-unassigned mailing list