[Webkit-unassigned] [Bug 259525] REGRESSION(266186 at main): Broke cloop build on all architectures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 26 11:10:33 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259525

Michael Catanzaro <mcatanzaro at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at redhat.com

--- Comment #1 from Michael Catanzaro <mcatanzaro at redhat.com> ---
$ git diff
diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp b/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
index f6da744880f3..a5873b0b58ca 100644
--- a/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
@@ -34,6 +34,7 @@
 #include "CLoopStackInlines.h"
 #include "CodeBlock.h"
 #include "CommonSlowPaths.h"
+#include "InPlaceInterpreter.h"
 #include "Interpreter.h"
 #include "LLIntCLoop.h"
 #include "LLIntData.h"

This fixes the above failures on x86_64, but I'm sure it will still be broken on other architectures, so more is needed.

However, there is another build failure that occurs next:

In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:434:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h: In static member function ‘static JSC::JSValue JSC::LLInt::CLoop::execute(JSC::OpcodeID, void*, JSC::VM*, JSC::ProtoCallFrame*, bool)’:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40233:1: error: ‘OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL’ was not declared in this scope; did you mean ‘OFFLINE_ASM_GLOBAL_LABEL’?
40233 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_unreachable_validate)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      | OFFLINE_ASM_GLOBAL_LABEL

This macro is new in 266186 at main and is only defined for ARM thumb2 CPUs, but it's used unconditionally. :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230726/bad14f90/attachment.htm>


More information about the webkit-unassigned mailing list