[Webkit-unassigned] [Bug 259525] New: REGRESSION(266186 at main): Broke cloop build on all architectures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 26 11:03:54 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259525

            Bug ID: 259525
           Summary: REGRESSION(266186 at main): Broke cloop build on all
                    architectures
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at redhat.com
                CC: daniel_liu4 at apple.com

It seems 266186 at main broke the cloop build on at least x86_64, ppc64le, and s390x. The generated LLIntAssembly.h is trying to use a bunch of declarations that don't exist:

In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:433:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h: In static member function ‘static JSC::JSValue JSC::LLInt::CLoop::execute(JSC::OpcodeID, void*, JSC::VM*, JSC::ProtoCallFrame*, bool)’:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40233:36: error: ‘ipint_unreachable_validate’ was not declared in this scope
40233 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_unreachable_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40233:1: error: ‘OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL’ was not declared in this scope; did you mean ‘OFFLINE_ASM_GLOBAL_LABEL’?
40233 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_unreachable_validate)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      | OFFLINE_ASM_GLOBAL_LABEL
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40238:36: error: ‘ipint_nop_validate’ was not declared in this scope
40238 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_nop_validate)
      |                                    ^~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40243:36: error: ‘ipint_block_validate’ was not declared in this scope
40243 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_block_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40248:36: error: ‘ipint_loop_validate’ was not declared in this scope
40248 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_loop_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40253:36: error: ‘ipint_if_validate’ was not declared in this scope
40253 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_if_validate)
      |                                    ^~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40258:36: error: ‘ipint_else_validate’ was not declared in this scope
40258 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_else_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40268:36: error: ‘ipint_end_validate’ was not declared in this scope
40268 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_end_validate)
      |                                    ^~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40273:36: error: ‘ipint_br_validate’ was not declared in this scope
40273 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_br_validate)
      |                                    ^~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40278:36: error: ‘ipint_br_if_validate’ was not declared in this scope
40278 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_br_if_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40283:36: error: ‘ipint_br_table_validate’ was not declared in this scope
40283 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_br_table_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40288:36: error: ‘ipint_return_validate’ was not declared in this scope
40288 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_return_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40293:36: error: ‘ipint_call_validate’ was not declared in this scope
40293 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_call_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40298:36: error: ‘ipint_call_indirect_validate’ was not declared in this scope
40298 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_call_indirect_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40311:36: error: ‘ipint_drop_validate’ was not declared in this scope
40311 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_drop_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40316:36: error: ‘ipint_select_validate’ was not declared in this scope
40316 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_select_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40321:36: error: ‘ipint_select_t_validate’ was not declared in this scope
40321 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_select_t_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40329:36: error: ‘ipint_local_get_validate’ was not declared in this scope
40329 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_local_get_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40334:36: error: ‘ipint_local_set_validate’ was not declared in this scope
40334 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_local_set_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/LLIntAssembly.h:40339:36: error: ‘ipint_local_tee_validate’ was not declared in this scope
40339 | OFFLINE_ASM_UNALIGNED_GLOBAL_LABEL(ipint_local_tee_validate)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated due to -fmax-errors=20.

I see that InPlaceInterpreter.h attempts to define these symbols only on aarch64 and x86_64, but the above build failure is actually on x86_64. (ppc64le and s390x fail in the same way.)

I need to investigate more to figure out what's going wrong, but my guess is there are at least two different problems here:

 * Broken on x86_64 due to missing #include? It's failing when building LowLevelInterpreter.cpp which notably does not #include InPlaceInterpreter.h
 * Broken on other architecturers due to improper conditional compilation? Looks like the code attempts to use the declarations on more architectures than they are declared on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230726/88e7b1b1/attachment-0001.htm>


More information about the webkit-unassigned mailing list